Commit @d413fe61ae17b5b38c74fbdfe069842167f1705c - yjyoon/ros2_플레이스테이션

WATANABE Aoi 2022-06-01

Merge pull request #7 from HarvestX/fix/dualsense-case

Dualsense -> DualSense

@d413fe61ae17b5b38c74fbdfe069842167f1705c

12157e6

d413fe6

README.md

--- README.md

+++ README.md


 
 ## Supported controllers
 
-| Status | Hardware Name |
-| ------ | ------------- |
+| Status               | Hardware Name |
+| -------------------- | ------------- |
 | :white_large_square: | `DualShock3`  |
 | :white_large_square: | `DualShock4`  |
-| :heavy_check_mark: | `Dualsense`   |
+| :heavy_check_mark:   | `DualSense`   |
 
 
 ## How to use the interface library
 1. Initialize controller interface with the specific hardware type.
 ```cpp
 // Initialize Interface
-const std::string hw_type = "Dualsense";
+const std::string hw_type = "DualSense";
 ps_interface =
   std::make_unique<p9n_interface::PlayStationInterface>(hw_type);
 ```

12157e6

d413fe6

p9n_example/launch/display.launch.py

--- p9n_example/launch/display.launch.py

+++ p9n_example/launch/display.launch.py


     launch_args = [
         DeclareLaunchArgument(
             'hw_type',
-            default_value=TextSubstitution(text='Dualsense')
+            default_value=TextSubstitution(text='DualSense')
         )
     ]
     nodes = [

12157e6

d413fe6

p9n_interface/include/p9n_interface/hw_types.hpp

--- p9n_interface/include/p9n_interface/hw_types.hpp

+++ p9n_interface/include/p9n_interface/hw_types.hpp


 {
 const char DUALSHOCK3[] = "DualShock3";
 const char DUALSHOCK4[] = "DualShock4";
-const char DUALSENSE[] = "Dualsense";
+const char DUALSENSE[] = "DualSense";
 }  // namespace HW_NAME
 }  // namespace p9n_interface

12157e6

d413fe6

p9n_test/README.md

--- p9n_test/README.md

+++ p9n_test/README.md


 ![Image](../media/test.png)
 
 ```bash
-ros2 launch p9n_test test.launch.py hw_type:=Dualsense
+ros2 launch p9n_test test.launch.py hw_type:=DualSense
 ```
 
 This process asks you to press the specific key. Then you need to press the actual hardware button of your controller and check all button interface step by step.

 And this repository supports following hardware.
 - `DualShock3`
 - `DualShock4`
-- `Dualsense`
+- `Dual
+- Sense`

12157e6

d413fe6

p9n_test/launch/test.launch.py

--- p9n_test/launch/test.launch.py

+++ p9n_test/launch/test.launch.py


     launch_args = [
         DeclareLaunchArgument(
             'hw_type',
-            default_value=TextSubstitution(text='Dualsense')
+            default_value=TextSubstitution(text='DualSense')
         )
     ]
     nodes = [

Add a comment

Open 0
Closed 0

List

...	...	@@ -28,7 +28,7 @@
28	28	launch_args = [
29	29	DeclareLaunchArgument(
30	30	'hw_type',
31		- default_value=TextSubstitution(text='Dualsense')
	31	+ default_value=TextSubstitution(text='DualSense')
32	32	)
33	33	]
34	34	nodes = [

...	...	@@ -30,6 +30,6 @@
30	30	{
31	31	const char DUALSHOCK3[] = "DualShock3";
32	32	const char DUALSHOCK4[] = "DualShock4";
33		-const char DUALSENSE[] = "Dualsense";
	33	+const char DUALSENSE[] = "DualSense";
34	34	} // namespace HW_NAME
35	35	} // namespace p9n_interface

...	...	@@ -28,7 +28,7 @@
28	28	launch_args = [
29	29	DeclareLaunchArgument(
30	30	'hw_type',
31		- default_value=TextSubstitution(text='Dualsense')
	31	+ default_value=TextSubstitution(text='DualSense')
32	32	)
33	33	]
34	34	nodes = [

...	...	@@ -4,18 +4,18 @@
4	4
5	5	## Supported controllers
6	6
7		-\| Status \| Hardware Name \|
8		-\| ------ \| ------------- \|
	7	+\| Status \| Hardware Name \|
	8	+\| -------------------- \| ------------- \|
9	9	\| :white_large_square: \| `DualShock3` \|
10	10	\| :white_large_square: \| `DualShock4` \|
11		-\| :heavy_check_mark: \| `Dualsense` \|
	11	+\| :heavy_check_mark: \| `DualSense` \|
12	12
13	13
14	14	## How to use the interface library
15	15	1. Initialize controller interface with the specific hardware type.
16	16	```cpp
17	17	// Initialize Interface
18		-const std::string hw_type = "Dualsense";
	18	+const std::string hw_type = "DualSense";
19	19	ps_interface =
20	20	std::make_unique<p9n_interface::PlayStationInterface>(hw_type);
21	21	```

...	...	@@ -5,7 +5,7 @@
5	5	![Image](../media/test.png)
6	6
7	7	```bash
8		-ros2 launch p9n_test test.launch.py hw_type:=Dualsense
	8	+ros2 launch p9n_test test.launch.py hw_type:=DualSense
9	9	```
10	10
11	11	This process asks you to press the specific key. Then you need to press the actual hardware button of your controller and check all button interface step by step.
...	...	@@ -14,4 +14,5 @@
14	14	And this repository supports following hardware.
15	15	- `DualShock3`
16	16	- `DualShock4`
17		-- `Dualsense`
	17	+- `Dual
	18	+- Sense`

Delete comment