Commit @e76455d55b48e33a6f5aa083dfeb8f893ed45edf - yjyoon/whisper_server

Fedir Zadniprovskyi 2024-09-22

test: switch to async openai client

@e76455d55b48e33a6f5aa083dfeb8f893ed45edf

db3aa0e

e76455d

tests/api_model_test.py

--- tests/api_model_test.py

+++ tests/api_model_test.py


 import openai
-from openai import OpenAI
+from openai import AsyncOpenAI
 import pytest
 
 MODEL_THAT_EXISTS = "Systran/faster-whisper-tiny.en"

 MIN_EXPECTED_NUMBER_OF_MODELS = 70  # At the time of the test creation there are 89 models
 
 
-def test_list_models(openai_client: OpenAI) -> None:
-    models = openai_client.models.list().data
+@pytest.mark.asyncio()
+async def test_list_models(openai_client: AsyncOpenAI) -> None:
+    models = (await openai_client.models.list()).data
     assert len(models) > MIN_EXPECTED_NUMBER_OF_MODELS
 
 
-def test_model_exists(openai_client: OpenAI) -> None:
-    model = openai_client.models.retrieve(MODEL_THAT_EXISTS)
+@pytest.mark.asyncio()
+async def test_model_exists(openai_client: AsyncOpenAI) -> None:
+    model = await openai_client.models.retrieve(MODEL_THAT_EXISTS)
     assert model.id == MODEL_THAT_EXISTS
 
 
-def test_model_does_not_exist(openai_client: OpenAI) -> None:
+@pytest.mark.asyncio()
+async def test_model_does_not_exist(openai_client: AsyncOpenAI) -> None:
     with pytest.raises(openai.NotFoundError):
-        openai_client.models.retrieve(MODEL_THAT_DOES_NOT_EXIST)
+        await openai_client.models.retrieve(MODEL_THAT_DOES_NOT_EXIST)

db3aa0e

e76455d

tests/conftest.py

--- tests/conftest.py

+++ tests/conftest.py


 from fastapi.testclient import TestClient
 from faster_whisper_server.main import create_app
 from httpx import ASGITransport, AsyncClient
-from openai import AsyncOpenAI, OpenAI
+from openai import AsyncOpenAI
 import pytest
 import pytest_asyncio
 

         yield aclient
 
 
-@pytest.fixture()
-def openai_client(client: TestClient) -> OpenAI:
-    return OpenAI(api_key="cant-be-empty", http_client=client)
+@pytest_asyncio.fixture()
+def openai_client(aclient: AsyncClient) -> AsyncOpenAI:
+    return AsyncOpenAI(api_key="cant-be-empty", http_client=aclient)
 
 
 @pytest.fixture()

Add a comment

Open 0
Closed 0

List

...	...	@@ -1,5 +1,5 @@
1	1	import openai
2		-from openai import OpenAI
	2	+from openai import AsyncOpenAI
3	3	import pytest
4	4
5	5	MODEL_THAT_EXISTS = "Systran/faster-whisper-tiny.en"
...	...	@@ -7,16 +7,19 @@
7	7	MIN_EXPECTED_NUMBER_OF_MODELS = 70 # At the time of the test creation there are 89 models
8	8
9	9
10		-def test_list_models(openai_client: OpenAI) -> None:
11		- models = openai_client.models.list().data
	10	+@pytest.mark.asyncio()
	11	+async def test_list_models(openai_client: AsyncOpenAI) -> None:
	12	+ models = (await openai_client.models.list()).data
12	13	assert len(models) > MIN_EXPECTED_NUMBER_OF_MODELS
13	14
14	15
15		-def test_model_exists(openai_client: OpenAI) -> None:
16		- model = openai_client.models.retrieve(MODEL_THAT_EXISTS)
	16	+@pytest.mark.asyncio()
	17	+async def test_model_exists(openai_client: AsyncOpenAI) -> None:
	18	+ model = await openai_client.models.retrieve(MODEL_THAT_EXISTS)
17	19	assert model.id == MODEL_THAT_EXISTS
18	20
19	21
20		-def test_model_does_not_exist(openai_client: OpenAI) -> None:
	22	+@pytest.mark.asyncio()
	23	+async def test_model_does_not_exist(openai_client: AsyncOpenAI) -> None:
21	24	with pytest.raises(openai.NotFoundError):
22		- openai_client.models.retrieve(MODEL_THAT_DOES_NOT_EXIST)
	25	+ await openai_client.models.retrieve(MODEL_THAT_DOES_NOT_EXIST)

...	...	@@ -5,7 +5,7 @@
5	5	from fastapi.testclient import TestClient
6	6	from faster_whisper_server.main import create_app
7	7	from httpx import ASGITransport, AsyncClient
8		-from openai import AsyncOpenAI, OpenAI
	8	+from openai import AsyncOpenAI
9	9	import pytest
10	10	import pytest_asyncio
11	11
...	...	@@ -32,9 +32,9 @@
32	32	yield aclient
33	33
34	34
35		-@pytest.fixture()
36		-def openai_client(client: TestClient) -> OpenAI:
37		- return OpenAI(api_key="cant-be-empty", http_client=client)
	35	+@pytest_asyncio.fixture()
	36	+def openai_client(aclient: AsyncClient) -> AsyncOpenAI:
	37	+ return AsyncOpenAI(api_key="cant-be-empty", http_client=aclient)
38	38
39	39
40	40	@pytest.fixture()

Delete comment